[
https://issues.apache.org/jira/browse/JDO-658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105445#comment-13105445
]
Michael Bouschen commented on JDO-658:
--------------------------------------
Hi Andy,
thanks for the review.
1. String.trim:
Yes you are right the code is testing against data in the datastore that
doesn't need trimming, because I could not find any test data suitable for
trimming. But I wanted to make sure that we have a query calling the trim
method inside a query.
2. Enum.ordinal:
The TCK class EnumMethodOrdinal is called from a different configuration file
jdoql1.conf, because I want to run it with mapping 1. Mapping1 uses schema1 and
this schema uses integer columns for the enums fields. So I think we are save
here. At least DN was able to run the query with this mapping, where I got
exceptions when running the test class with the regular mapping.
> JDOQL : Support for further methods (String, Enum, Date, JDOHelper)
> -------------------------------------------------------------------
>
> Key: JDO-658
> URL: https://issues.apache.org/jira/browse/JDO-658
> Project: JDO
> Issue Type: New Feature
> Components: specification, tck
> Affects Versions: JDO 3
> Reporter: Andy Jefferson
> Fix For: JDO 3 maintenance release 1
>
> Attachments: JDO-658-mbo.patch, JDO-658.patch,
> jdohelper_getversion.patch
>
>
> Consider extending JDOQL in JDO3.1 to include a series of new methods,
> following the contracts of existing Java classes
> String.charAt(int)
> String.startsWith(String, int)
> String.length()
> String.trim()
> Enum.ordinal()
> Enum.toString()
> The following are obviously deprecated in the JDK, but worth consideration
> Date.getHour()
> Date.getMinutes()
> Date.getSeconds()
> Date.getDay()
> Date.getMonth()
> Date.getYear()
> We already have JDOHelper.getObjectId(Object), so why not add
> JDOHelper.getVersion(Object)
> On a related topic JDO-633 has "List.get(int)".
> Note that all of these are already implemented in the RI.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
