jde-run-etrace-goto doesn't work with CVS Emacs.
It uses compilation-goto-locus which now takes three arguments.
This problem has been mentioned on the list a couple of months ago.
But it hasn't been fixed so far.

Since there are many code breaking changes in Emacs 21.4,
I've defined a predicate in jde.el which is true
for all GNU Emacs versions newer than 21.3 (including "21.3.50.1" ...).
It's called jde-emacs21-4p.

The diffs below are based on the files distributed with JDEE 2.3.5.

BTW, there is a new precompiled CVS Emacs for Windows available at:

http://www.crasseux.com/emacs/

Martin


diff -u jde.el.old jde.el --- jde.el.old 2004-12-17 05:29:36.000000000 +0100 +++ jde.el 2004-12-20 10:16:21.000000000 +0100 @@ -53,6 +53,11 @@ (defconst jde-emacs21p (and (string-match "\\bEmacs\\b" (emacs-version)) (>= emacs-major-version 21)))

+(defconst jde-emacs21-4p (and jde-emacs21p
+                              (or (> emacs-major-version 21)
+                                  (> emacs-minor-version 3)
+                                  (> (length emacs-version) 4))))
+
 (unless (fboundp 'custom-set-default)
    (defalias 'custom-set-default 'set-default))




diff -u jde-run.el.old jde-run.el --- jde-run.el.old 2004-12-17 05:29:36.000000000 +0100 +++ jde-run.el 2004-12-20 11:04:57.000000000 +0100 @@ -1553,8 +1553,12 @@

 (defun jde-run-etrace-goto (&optional next)
   "Display the current stack using `compilation-goto-locus'."
-  (compilation-goto-locus (jde-run-etrace-current-marker next)))
-
+  (jde-run-etrace-current-marker next)
+  (if jde-emacs21-4p
+      (compilation-goto-locus (car jde-run-etrace-current-marker)
+                              (cdr jde-run-etrace-current-marker)
+                              nil)
+    (compilation-goto-locus jde-run-etrace-current-marker)))

 (defun jde-run-etrace-show-at-mouse (event)
   "Jump to the stack position at the mouse click.



Reply via email to