>>>>> "Vaclav" == Vaclav Barta <[EMAIL PROTECTED]> writes:
Vaclav> Steve Youngs wrote:
>> APPROVE COMMIT
>> |--==> "VB" == Vaclav Barta <[EMAIL PROTECTED]> writes:
VB> 2002-03-04 Vaclav Barta <[EMAIL PROTECTED]>
VB> * jde.el: use get-file-buffer to map pathname to buffer
>> Thanks very much for the patch, Vaclav. I'll apply this shortly.
Vaclav> Er, I've been looking at JDE upstream, and it seems (I didn't test) that
Vaclav> the problem is already fixed in a new beta (2.2.9beta9.1). I do think
Vaclav> the fix is sub-optimal - it uses (the same) lambda in
Vaclav> jde-save-close-buffer and jde-save-variable, where get-file-buffer could
Vaclav> IMHO be used instead - but I'm not sure whether such details are worth
Vaclav> gold-plating... Perhaps there are compatibility problems with
Vaclav> get-file-buffer?
Vaclav> Bye
Vaclav> Vasek
Vaclav> P.S.: on the other hand, looking at the jde-save-variable again, how is
Vaclav> it
Vaclav> supposed to work? The fixed (note the comment) lambda is
Vaclav> (lambda (buf)
Vaclav> (let* ((directory-sep-char ?/) ;; XEmacs defaults to backslash
Vaclav> (buf-file-name (buffer-file-name buf)))
Vaclav> (and buf-file-name
Vaclav> (string= (car project)
Vaclav> (expand-file-name buf-file-name)))))
Vaclav> Apparently buffer-file-name depends on the value of
Vaclav> directory-sep-char (not that it's documented); but isn't
Vaclav> directory-sep-char above declared just locally, i.e. a
Vaclav> different variable from the global one?
clearcase.el, before it became the clearcase package, used to cause
buffer file names to use ?\ as separator, irregardless of
directory-sep-char.
This is bad!
It showed up as a mix of / and \ separated filename paths in the
*Buffer List* (those before clearcase was loaded, and those after) :-(
Do you see something like this in jde too?
Under Windows, the cygwin build sets directory-sep-char to ?/ and the
native build sets it to ?\ and packages must be able to deal with
both.
I can even change directory-sep-char in the middle of my XEmacs
session and things still work.
Does jde keep the local binding of directory-sep-char internal, or
does it cause any external side-effects (like clearcase used to)?
Best regards,
Adrian
--
Adrian Aichner
mailto:[EMAIL PROTECTED]
http://www.xemacs.org/
