On Monday 30 November 2009 14:24:20 Michael McCandless wrote:
> I agree, it's silly we label things like TopDocs/TopFieldDocs as
> expert -- they are no longer for "low level" APIs (or, perhaps since
> we've removed the "high level" API (= Hits), what remains should no
> longer be considered low level).
>
> Do you wanna cough up a patch to correct these?

I'd do, but was not successful to get the svn repo some months ago. I 
have to claim the sys admin for any svn repo to open a door through the 
firewall. Gave up due to

$ nmap -p3690 svn.apache.org
    PORT     STATE    SERVICE
    3690/tcp filtered unknown

But I got the git repo at http://git.apache.org/lucene.git/
That works out of the box. So the remaining hurdle is to create the 
patches. If there is no way to accept git patches (see attachment, they 
are somewhat different) I'd try to setup the git-svn bridge locally, 
just to create the patches.

Stefan
diff --git a/src/java/org/apache/lucene/search/TopDocs.java 
b/src/java/org/apache/lucene/search/TopDocs.java
index 7e53662..0f098e1 100644
--- a/src/java/org/apache/lucene/search/TopDocs.java
+++ b/src/java/org/apache/lucene/search/TopDocs.java
@@ -17,13 +17,13 @@ package org.apache.lucene.search;
  * limitations under the License.
  */
 
-/** Expert: Returned by low-level search implementations.
+/**
  * @see Searcher#search(Query,Filter,int) */
 public class TopDocs implements java.io.Serializable {
   /** Expert: The total number of hits for the query.
   */
   public int totalHits;
-  /** Expert: The top hits for the query. */
+  /** The top hits for the query. */
   public ScoreDoc[] scoreDocs;
   /** Expert: Stores the maximum score value encountered, needed for 
normalizing. */
   private float maxScore;

---------------------------------------------------------------------
To unsubscribe, e-mail: java-user-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-user-h...@lucene.apache.org

Reply via email to