>>BTW, if you have a small test index with multiple commit points could you >>please send it to me off the list?
See the "setup" method in the junit test "TestTransactionRollbackCapability2" attached here: https://issues.apache.org/jira/browse/LUCENE-1449 Cheers, Mark ----- Original Message ---- From: Andrzej Bialecki <[EMAIL PROTECTED]> To: java-user@lucene.apache.org Sent: Friday, 14 November, 2008 10:47:03 Subject: Re: [ANN] Luke 0.9 released mark harwood wrote: > Hi Andrzej, > > Thanks for the update. Looks like you've been busy adding some great > new features! > > I think you may have a bug in opening an index with prior commit > points, though. I want to keep these in my index and so I opened it > in Luke selecting the "open read only" and "keep all commit points" > checkboxes. I can see in the code that under these conditions you > take care to use a "KeepAllDeletionPolicy" but line 176 of > IndexGate.java is hardcoded with a > "KeepOnlyLastCommitDeletionPolicy". This wiped my prior commit points > (No worries - it was only a test index). Sorry about that - I'm glad it was disposable data. BTW, if you have a small test index with multiple commit points could you please send it to me off the list? > The call stack leading to this code was: Luke.showFiles > Luke.getIndexDeletableNames IndexGate.GetDeletableFiles > > The fix could be to pass the policy through this stack but may > "opening read only" should mean just that and NO deletes at all are > ever done - regardless? Theoretically when you open a read-only IndexReader you can't delete anything using that IndexReader, but in practice Luke directly accesses the underlying Directory in many other places ... I forgot about the use of IndexFileDeleter - and indeed passing the read-only flag here can solve this, because then I can always use KeepAllDeletionPolicy when opening read-only. Thanks for the report! -- Best regards, Andrzej Bialecki <>< ___. ___ ___ ___ _ _ __________________________________ [__ || __|__/|__||\/| Information Retrieval, Semantic Web ___|||__|| \| || | Embedded Unix, System Integration http://www.sigram.com Contact: info at sigram dot com --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
