[
https://issues.apache.org/jira/browse/ZOOKEEPER-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-1234:
--------------------------------------
Labels: pull-request-available (was: )
> basic cleanup in LearnerHandler
> -------------------------------
>
> Key: ZOOKEEPER-1234
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1234
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Major
> Labels: pull-request-available
> Attachments: ZOOKEEPER-1234.patch, ZOOKEEPER-1234.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> - order class members: properties, constructor, methods
> - make properties private final
> - rename version to protocolVersion
> - The integer value 0x10000 should be extracted to a constant with a
> declarative name. But since I don't yet fully understand its purpose, I've no
> idea for the name of the constant.
> - Initialize properties BinaryInpuutArchive ia, BinaryOutputArchive oa and
> BuferedOutputSream bufferedOutput in the constructor so that they can be made
> final.
> - Remove call to sock.setSoTimeout. All two users of the class set the
> sockettimeout anyways themselfes. This also removes a link to the Leader
> class.
> - remove unused method packetToString.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
