[
https://issues.apache.org/jira/browse/YUNIKORN-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18008888#comment-18008888
]
Wilfred Spiegelenburg commented on YUNIKORN-2975:
-------------------------------------------------
The [makefile|https://github.com/apache/yunikorn-web/blob/master/Makefile#L275]
passes in a node version based on what is set in the .nvmrc file.
Based on the docker documentation we have defined the ARG to read that
NODE_VERSION we set:
{code:java}
ARG <name>[=<default value>] [<name>[=<default value>]...] {code}
That shows in our dockerfile as
{code:java}
ARG NODE_VERSION=20{code}
The default value is 20 unless the ARG is set based on this:
{code:java}
If an ARG instruction has a default value and if there is no value passed at
build-time, the builder uses the default. {code}
The Makefile sets the arg so we do the correct thing.
> web image build does not use .nvmrc
> -----------------------------------
>
> Key: YUNIKORN-2975
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2975
> Project: Apache YuniKorn
> Issue Type: Task
> Components: webapp
> Reporter: Wilfred Spiegelenburg
> Assignee: Tzu-Hua Lan
> Priority: Major
>
> In the Docker file we use to build the image we have hardcoded a version of
> node.
> {code:java}
> ARG NODE_VERSION=20
> # Buildstage: use the local architecture
> FROM --platform=$BUILDPLATFORM node:${NODE_VERSION}-alpine AS buildstage
> {code}
> This causes issues as the real version that it points to can change from one
> build to another. We should be using the version we set in the {{.nvmrc}} as
> that would also be the version we install as a tool and that has been used by
> the developer.
> Currently the versions are also out of sync 18.20 vs 20.
> Part of the change we should also move to node 22.11.0 to get to the latest
> LTS that is supported with the angular release we use.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
