[
https://issues.apache.org/jira/browse/TS-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363408#comment-15363408
]
ASF GitHub Bot commented on TS-3816:
------------------------------------
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/783#discussion_r69650806
--- Diff: proxy/http/HttpTransact.cc ---
@@ -63,7 +63,12 @@ static char range_type[] = "multipart/byteranges;
boundary=RANGE_SEPARATOR";
extern HttpBodyFactory *body_factory;
-static const char local_host_ip_str[] = "127.0.0.1";
+inline static bool
+is_localhost(const char *name, int len)
--- End diff --
I should say, I'm fine punting on that for later, just file a separate Jira
on unifying "localhost" comparisons.
> Should we replace ptr_len_cmp() with memcmp() consistently?
> -----------------------------------------------------------
>
> Key: TS-3816
> URL: https://issues.apache.org/jira/browse/TS-3816
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core
> Reporter: Leif Hedstrom
> Assignee: Tyler Stroh
> Labels: newbie++
> Fix For: sometime
>
>
> In most places, we already use memcmp(), but we have our own implementation /
> wrapper named ptr_len_cmp(), which is used in a few places. This seems rather
> inconsistent, so either we use ptr_len_cmp() consistently, or just use
> memcmp() across the board.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
