[
https://issues.apache.org/jira/browse/TS-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15359616#comment-15359616
]
ASF GitHub Bot commented on TS-3816:
------------------------------------
GitHub user strotyl opened a pull request:
https://github.com/apache/trafficserver/pull/783
TS-3816 : Replace ptr_len_cmp with memcmp
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/strotyl/trafficserver TS-3816
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/783.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #783
----
commit b1b29deeb30ff6e61c99032ed8f314fbe87b155d
Author: Tyler Stroh <[email protected]>
Date: 2016-06-27T21:52:43Z
TS-3816 : Replace ptr_len_cmp with memcmp
----
> Should we replace ptr_len_cmp() with memcmp() consistently?
> -----------------------------------------------------------
>
> Key: TS-3816
> URL: https://issues.apache.org/jira/browse/TS-3816
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core
> Reporter: Leif Hedstrom
> Assignee: Tyler Stroh
> Labels: newbie++
> Fix For: sometime
>
>
> In most places, we already use memcmp(), but we have our own implementation /
> wrapper named ptr_len_cmp(), which is used in a few places. This seems rather
> inconsistent, so either we use ptr_len_cmp() consistently, or just use
> memcmp() across the board.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
