[ 
https://issues.apache.org/jira/browse/TS-4623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15359321#comment-15359321
 ] 

ASF GitHub Bot commented on TS-4623:
------------------------------------

Github user jpeach commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/777#discussion_r69330732
  
    --- Diff: tools/pre-commit ---
    @@ -0,0 +1,66 @@
    +#! /usr/bin/env bash
    +#
    +#  Simple pre-commit hook script, enforcing clang-format on our tree
    +#
    +#  Licensed to the Apache Software Foundation (ASF) under one
    +#  or more contributor license agreements.  See the NOTICE file
    +#  distributed with this work for additional information
    +#  regarding copyright ownership.  The ASF licenses this file
    +#  to you under the Apache License, Version 2.0 (the
    +#  "License"); you may not use this file except in compliance
    +#  with the License.  You may obtain a copy of the License at
    +#
    +#      http://www.apache.org/licenses/LICENSE-2.0
    +#
    +#  Unless required by applicable law or agreed to in writing, software
    +#  distributed under the License is distributed on an "AS IS" BASIS,
    +#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +#  See the License for the specific language governing permissions and
    +#  limitations under the License.
    +
    +ROOT=$(git rev-parse --show-toplevel)/.git/fmt
    +case $(uname -s) in
    +Darwin)
    +    FORMAT=${FORMAT:-${ROOT}/clang-format/clang-format.osx}
    +    ;;
    +Linux)
    +    FORMAT=${FORMAT:-${ROOT}/clang-format/clang-format.linux}
    +    ;;
    +*)
    +    echo "Leif needs to build a clang-format for $(uname -s)"
    --- End diff --
    
    Just run $(git rev-parse --show-toplevel)/tools/clang-format.sh here ?


> Add a pre-commit shell script
> -----------------------------
>
>                 Key: TS-4623
>                 URL: https://issues.apache.org/jira/browse/TS-4623
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Leif Hedstrom
>            Assignee: Leif Hedstrom
>             Fix For: 7.0.0
>
>
> I have a little script that helps enforcing proper clang-format on git commit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to