[
https://issues.apache.org/jira/browse/TS-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15296473#comment-15296473
]
ASF GitHub Bot commented on TS-4469:
------------------------------------
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/657#discussion_r64237117
--- Diff: proxy/http2/Http2Stream.cc ---
@@ -241,17 +243,22 @@ Http2Stream::do_io_close(int /* flags */)
{
current_reader = NULL; // SM on the way out
if (!sent_delete) {
+ SCOPED_MUTEX_LOCK(lock, this->mutex, this_ethread());
--- End diff --
I don't know this code at all, but it seems a little scary to hold this
mutex for so long. Particularly since it's still being held when we reenable SM
? And it's also held across the calls to a number of other methods, which
hopefully are not trying to lock anything, but it seems like we could easily
open up the possibilities of deadlocks here.
> TS-3612 changes cause crashes with some plugins
> -----------------------------------------------
>
> Key: TS-4469
> URL: https://issues.apache.org/jira/browse/TS-4469
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
> Affects Versions: 6.2.0
> Reporter: Susan Hinrichs
> Assignee: Susan Hinrichs
> Labels: crash, regresion
> Fix For: 7.0.0
>
>
> Reported by [~biilmann] and similar issues seen in Yahoo. Possibly related
> to TS-4454.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
