[
https://issues.apache.org/jira/browse/TS-4020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274097#comment-15274097
]
ASF GitHub Bot commented on TS-4020:
------------------------------------
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/619
TS-4020 Use cache-key URL for some plugins
cache_promote and background_fetch both use the pristine URL
as the hash for various internal lookup features. This works
well, except when it doesn't. For example, when mixed with
using the cachekey.so plugin.
This changes the behavior to use the cachekey URL. This is not
awesomely efficient at this point, but a future fix will use a
new API that allows introspection into the actual cache key used
by the ATS core instead.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zwoop/trafficserver TS-4020
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/619.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #619
----
commit b7d5b28949f26f81745d0be55d8eefdebf01d46c
Author: Leif Hedstrom <[email protected]>
Date: 2016-04-28T22:09:48Z
TS-4020 Use cache-key URL for some plugins
cache_promote and background_fetch both use the pristine URL
as the hash for various internal lookup features. This works
well, except when it doesn't. For example, when mixed with
using the cachekey.so plugin.
This changes the behavior to use the cachekey URL. This is not
awesomely efficient at this point, but a future fix will use a
new API that allows introspection into the actual cache key used
by the ATS core instead.
----
> Cache_promote/background_fetch plugin LRU should use cachekey instead of url
> ----------------------------------------------------------------------------
>
> Key: TS-4020
> URL: https://issues.apache.org/jira/browse/TS-4020
> Project: Traffic Server
> Issue Type: Bug
> Components: Plugins
> Reporter: Miles Libbey
> Assignee: Leif Hedstrom
> Labels: A
> Fix For: 7.0.0
>
>
> The Cache_promote plugin currently uses the URL when using the LRU policy.
> It would be better to use the cachekey, as that is actually going to be the
> index later.
> This would make any cachekey modifications also work for the promotion
> algorithm. For instance, if a domain has a (randomish) query string that gets
> removed for the cachekey, using the URL in the LRU would effectively never
> allow it to be promoted to cache, whereas the cachekey would.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
