[
https://issues.apache.org/jira/browse/TS-4055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069787#comment-15069787
]
ASF GitHub Bot commented on TS-4055:
------------------------------------
Github user shinrich commented on the pull request:
https://github.com/apache/trafficserver/pull/373#issuecomment-166932419
The change is small enough to be reasonable defensive code. And it if got
rid of your crash, that is great.
However, a better solution may be to assign the server_entry->write_vio in
HttpSM::attach_server_session around line 5692
{code}
// Transfer control of the write side as well
server_session->do_io_write(this, 0, NULL);
{code}
The call to do_io_read above assigned the results to
server_entry->read_vio. We should do the same thing for the
server_entry->write_vio. Since the server_entry is set in this function, if we
set server_entry->write_vio here too, there would be no path with an unset
write_vio.
> Coredump when closing a transaction with a stalled connection to the origin
> -----------------------------------------------------------------------------
>
> Key: TS-4055
> URL: https://issues.apache.org/jira/browse/TS-4055
> Project: Traffic Server
> Issue Type: Bug
> Affects Versions: 6.0.1
> Reporter: bettydramit
> Assignee: Bryan Call
> Labels: crash
> Fix For: 6.0.1, 6.1.0
>
>
> {code}
> c++filt <a.txt
> traffic_server: Segmentation fault (Address not mapped to object [0x8])
> traffic_server - STACK TRACE:
> /usr/bin/traffic_server(crash_logger_invoke(int, siginfo_t*,
> void*)+0x8e)[0x4abf4e]
> /lib64/libpthread.so.0(+0x10430)[0x2abaac562430]
> /usr/bin/traffic_server(HttpSM::handle_server_setup_error(int,
> void*)+0x25b)[0x5b5d0b]
> /usr/bin/traffic_server(HttpSM::state_send_server_request_header(int,
> void*)+0x142)[0x5c0dd2]
> /usr/bin/traffic_server(HttpSM::main_handler(int, void*)+0xc8)[0x5c5e38]
> /usr/bin/traffic_server(UnixNetVConnection::mainEvent(int,
> Event*)+0x4ff)[0x78651f]
> /usr/bin/traffic_server(InactivityCop::check_inactivity(int,
> Event*)+0x28d)[0x7789ad]
> /usr/bin/traffic_server(EThread::process_event(Event*, int)+0x8a)[0x7bdf5a]
> /usr/bin/traffic_server(EThread::execute()+0xaa5)[0x7bf045]
> /usr/bin/traffic_server[0x7bda25]
> /lib64/libpthread.so.0(+0x7555)[0x2abaac559555]
> /lib64/libc.so.6(clone+0x6d)[0x2abaad67bb9d]
> Dec 05 21:00:12 localhost sendEmail[23289]: Email was sent successfully!
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
