[
https://issues.apache.org/jira/browse/TS-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047377#comment-15047377
]
ASF GitHub Bot commented on TS-4030:
------------------------------------
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/369#issuecomment-162997233
This mostly looks good, except in
+char *
+ParentRecord::getHashPath(RequestData *rdata, size_t *path_len)
+{
I think, but not 100% sure, that this effectively always strips the query
parameter. My reasoning for this is that this ought to always just return the
path (without the query params):
path = const_cast<char *>(hrdata->hdr->path_get(&plen));
Right?
> Add option to remove query string from URL hashing in consistent hash parent
> selection method.
> ----------------------------------------------------------------------------------------------
>
> Key: TS-4030
> URL: https://issues.apache.org/jira/browse/TS-4030
> Project: Traffic Server
> Issue Type: Improvement
> Reporter: Phil Sorber
> Assignee: Phil Sorber
> Labels: A
> Fix For: 6.1.0
>
>
> You most likely will not want to hash on the query string, so we should have
> an option to remove it from consideration.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
