[
https://issues.apache.org/jira/browse/TS-3998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006015#comment-15006015
]
ASF GitHub Bot commented on TS-3998:
------------------------------------
GitHub user syucream opened a pull request:
https://github.com/apache/trafficserver/pull/338
TS-3998: Disable h2c upgrades
https://issues.apache.org/jira/browse/TS-3998
Reject h2c token for now. after applying this patch, h2c upgrading is
handled as Invalid Upgrade Request.
```
$ nghttp -v -u http://127.0.0.1/
...
[ 0.001] HTTP Upgrade response
HTTP/1.1 400 Invalid Upgrade Request
Date: Sun, 15 Nov 2015 20:06:14 GMT
Connection: keep-alive
Server: ATS/6.1.0
Cache-Control: no-store
Content-Type: text/html
Content-Language: en
Content-Length: 220
...
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/syucream/trafficserver disable_h2c_upgrade
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/338.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #338
----
commit 26491816f47efa1bc9699c361c65a6857bd6bdaa
Author: Ryo Okubo <[email protected]>
Date: 2015-11-15T19:19:46Z
TS-3998: Disable h2c upgrades
----
> Disable h2c upgrades (for now)
> ------------------------------
>
> Key: TS-3998
> URL: https://issues.apache.org/jira/browse/TS-3998
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP/2
> Reporter: Leif Hedstrom
> Assignee: Ryo Okubo
> Fix For: 6.1.0
>
>
> I see
> {code}
> loki (09:37) 259/0 $ nghttp -v -u http://docs.trafficserver.apache.org
> [ 0.031] Connected
> [ 0.031] HTTP Upgrade request
> GET / HTTP/1.1
> Host: docs.trafficserver.apache.org
> Connection: Upgrade, HTTP2-Settings
> Upgrade: h2c-14
> HTTP2-Settings: AAMAAABkAAQAAP__
> Accept: */*
> User-Agent: nghttp2/0.7.4-DEV
> [ 0.066] HTTP Upgrade response
> HTTP/1.1 101 Switching Protocols
> Date: Sun, 05 Apr 2015 15:37:58 GMT
> Connection: Upgrade
> Via: http/1.1 ATS (ApacheTrafficServer/5.3.0 [c s f ])
> Server: ATS/5.3.0
> Upgrade: h2c-14
> [ 0.066] HTTP Upgrade success
> [ 0.066] recv SETTINGS frame <length=36, flags=0x00, stream_id=0>
> (niv=6)
> [SETTINGS_HEADER_TABLE_SIZE(0x01):4096]
> [SETTINGS_ENABLE_PUSH(0x02):0]
> [SETTINGS_MAX_CONCURRENT_STREAMS(0x03):66]
> [SETTINGS_INITIAL_WINDOW_SIZE(0x04):123456]
> [SETTINGS_MAX_FRAME_SIZE(0x05):16384]
> [SETTINGS_MAX_HEADER_LIST_SIZE(0x06):4294967295]
> [ 0.066] send SETTINGS frame <length=12, flags=0x00, stream_id=0>
> (niv=2)
> [SETTINGS_MAX_CONCURRENT_STREAMS(0x03):100]
> [SETTINGS_INITIAL_WINDOW_SIZE(0x04):65535]
> [ 0.066] send SETTINGS frame <length=0, flags=0x01, stream_id=0>
> ; ACK
> (niv=0)
> [ 0.097] recv SETTINGS frame <length=0, flags=0x01, stream_id=0>
> ; ACK
> (niv=0)
> {code}
> And then it hangs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
