[ 
https://issues.apache.org/jira/browse/TS-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622801#comment-14622801
 ] 

Leif Hedstrom commented on TS-2150:
-----------------------------------

This sets a pretty bad precedence too on using STL for no good reason 
whatsoever. I understand this is only under initialization? So, I feel strongly 
that this should either be changed to use our existing hash container, or 
Vector, or something. Or, if this is not performance sensitive, just loop over 
the array, or make it a SList or something else simple.

Yes, this doesn't affect the critical path, but it is done for (as far as I can 
tell) for no good reasons other than convenience? Lets leave STL out should 
still be a generic goal until we, as a community, has agreed otherwise. I'm 
opening a new Jira to eliminate these use of STL containers.

> Add Milestone log tags
> ----------------------
>
>                 Key: TS-2150
>                 URL: https://issues.apache.org/jira/browse/TS-2150
>             Project: Traffic Server
>          Issue Type: New Feature
>          Components: Logging
>            Reporter: Leif Hedstrom
>            Assignee: François Pesce
>              Labels: yahoo
>             Fix For: 6.1.0
>
>
> We have a notion of milestones in the core, and plugin APIs 
> (TSHttpTxnMilestoneGet() ). It'd be useful to expose these milestone timers 
> as a log tag, something like:
> {code}
> %<{UA_BEGIN}mtms>
> {code}
> mtms is just an example / suggestion, "MilestoneTimeMilliSecond", we can make 
> it whatever we like.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to