[ 
https://issues.apache.org/jira/browse/TS-3449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudheer Vinukonda updated TS-3449:
----------------------------------
    Description: 
[~zwoop] noticed that the naming of the API TSHttpIsInternalRequest() is a 
little bit confusing, since it takes in a txnp parameter. It would perhaps be 
clearer if the API were called TSHttpTxnIsInternal. (incidentally, there's a 
condition in header_rewrite plugin that is also named INTERNAL-TRANSACTION - 
TS-2834).

To remove the confusion, Leif suggested to duplicate the existing TS API 
TSHttpIsInternalRequest() as TSHttpIsInternalTransaction() and eventually 
retire the TSHttpIsInternalRequest() API.

  was:
[~zwoop] noticed that the naming of the API TSHttpIsInternalRequest() is a 
little bit confusing, since it takes in a txnp parameter. It would perhaps be 
clearer if the API were called TSHttpIsInternalTransaction. (incidentally, 
there's a condition in header_rewrite plugin that is also named 
INTERNAL-TRANSACTION - TS-2834).

To remove the confusion, Leif suggested to duplicate the existing TS API 
TSHttpIsInternalRequest() as TSHttpIsInternalTransaction() and eventually 
retire the TSHttpIsInternalRequest() API.


> Create a dup TS API of TSHttpIsInternalRequest with name TSHttpTxnIsInternal
> ----------------------------------------------------------------------------
>
>                 Key: TS-3449
>                 URL: https://issues.apache.org/jira/browse/TS-3449
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: TS API
>    Affects Versions: 5.3.0
>            Reporter: Sudheer Vinukonda
>             Fix For: 6.0.0
>
>
> [~zwoop] noticed that the naming of the API TSHttpIsInternalRequest() is a 
> little bit confusing, since it takes in a txnp parameter. It would perhaps be 
> clearer if the API were called TSHttpTxnIsInternal. (incidentally, there's a 
> condition in header_rewrite plugin that is also named INTERNAL-TRANSACTION - 
> TS-2834).
> To remove the confusion, Leif suggested to duplicate the existing TS API 
> TSHttpIsInternalRequest() as TSHttpIsInternalTransaction() and eventually 
> retire the TSHttpIsInternalRequest() API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to