[
https://issues.apache.org/jira/browse/TS-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14339712#comment-14339712
]
ASF GitHub Bot commented on TS-3396:
------------------------------------
Github user ericcarlschwartz commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/172#discussion_r25487671
--- Diff: ci/new_tsqa/tests/test_spdy_protocol_select.py ---
@@ -0,0 +1,141 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import os
+import requests
+import time
+import logging
+import subprocess
+
+import helpers
+
+import tsqa.test_cases
+import tsqa.utils
+import tsqa.endpoint
+
+log = logging.getLogger(__name__)
+
+class TestSPDY(helpers.EnvironmentCase):
+ environment_factory = {
+ 'configure': {'enable-spdy': None},
+ 'env': {'PKG_CONFIG_PATH': '/opt/spdylay/lib/pkgconfig/'},
+ }
+
+ @classmethod
+ def setUpEnv(cls, env):
+ '''
+ This function is responsible for setting up the environment for
this fixture
+ This includes everything pre-daemon start
+ '''
+
+ # set up spdycat
+ build_dir = os.environ.get('top_builddir', '../..')
+ cls.client = '%s/spdylay/src/spdycat' % build_dir
--- End diff --
spdylay comes with spdycat. if the ats getting started with spdy guide is
how spdylay is installed this path would point to the binary, but i think your
idea of checking that spdycat is in the PATH is a better one. we can just have
the tests check and skip if it's missing.
> new_tsqa SPDY protocol selection tests
> --------------------------------------
>
> Key: TS-3396
> URL: https://issues.apache.org/jira/browse/TS-3396
> Project: Traffic Server
> Issue Type: Test
> Components: SPDY, tsqa
> Reporter: Eric Schwartz
> Assignee: Thomas Jackson
> Priority: Minor
> Fix For: sometime
>
>
> Opening this JIRA to submit some SPDY protocol selection tests using spdycat
> I wrote using the new_tsqa.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
