[
https://issues.apache.org/jira/browse/TS-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13919680#comment-13919680
]
Leif Hedstrom commented on TS-2609:
-----------------------------------
Right, significant portions of the URL / CLIENT-URL features are not
implemented.
Also, looking at the docs, it seems the intent was to implement these three:
{code}
header_rewrite.en.rst: cond %{HOST} operand
[condition_flags]
header_rewrite.en.rst: cond %{FROMHOST} operand [condition_flags]
header_rewrite.en.rst: cond %{TOHOST} operand
[condition_flags]
{code}
I'm pretty sure each of those would correlate (in remap plugins) to each of
these from the RRI struct:
{code}
TSMLoc requestUrl;
TSMLoc mapFromUrl;
TSMLoc mapToUrl;
{code}
So, your original patch, the condition would be named "HOST" I think? Also, I
feel that to be consistent, the three conditions ought to be be named
{code}
HOST
FROM-HOST
TO-HOST
{code}
That seems more in line with how we do this for e.g. HEADER / CLIENT-HEADER and
URL / CLIENT-URL.
Finally, the intent probably also was (just as with URL / CLIENT-URL) that we'd
have one class implementing "HOST", and have it use a flag to indicate which
type of HOST it would use.
Wdyt ?
Oh, and thanks for all the input, this is a good discussion!
> Header rewrite plugin TOHOST condition
> --------------------------------------
>
> Key: TS-2609
> URL: https://issues.apache.org/jira/browse/TS-2609
> Project: Traffic Server
> Issue Type: Improvement
> Components: Plugins
> Reporter: Anil Kumar Myla
> Assignee: Leif Hedstrom
> Priority: Minor
> Fix For: 5.0.0
>
>
> Enhance header rewrite plugin to support TOHOST condition. Header rewrites
> conditioned on the final origin server will be supported.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
