[ 
https://issues.apache.org/jira/browse/TS-2424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13844575#comment-13844575
 ] 

ASF subversion and git services commented on TS-2424:
-----------------------------------------------------

Commit 4b94cdfd7942595fc461344f1bae834672e84502 in branch refs/heads/master 
from [[email protected]]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=4b94cdf ]

TS-2424: set diags log file for each caller

Since DiagsConfig.cc is built into a static library, we can't rely
on the preprocessor to determine what the diagnostic log file should
be. Add a filename to the constructor so that each usage uses an
explicit name.


> fix broken manager diagnostics
> ------------------------------
>
>                 Key: TS-2424
>                 URL: https://issues.apache.org/jira/browse/TS-2424
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Core, Logging, Quality
>            Reporter: James Peach
>            Assignee: James Peach
>             Fix For: 4.2.0
>
>
> The diagnostic logging was broken by a build change made by 
> {{efe90f3fecb10605f35bbfe557f19534b9e6fce7}}. In the original build, the digs 
> subsystem was built multiple times for {{traffic_server}} and 
> {{traffic_server}} with different preprocessor flags. Now that 
> {{DiagsConfig.cc}} is built into a convenience library, this does not happen, 
> and {{manager.log}} is no longer created.
> The commit that broke this actually moved the build in the right direction, 
> so I'm just going to finish that off. We can make a new library, 
> {{libdiags.a}} that depends on both {{lib's.a}} and {{librecords.a}}. 
> {{traffic_server}} and {{traffic_manager}} can both link against this and 
> make the configuration change at runtime.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Reply via email to