[
https://issues.apache.org/jira/browse/TS-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13748892#comment-13748892
]
Alan M. Carroll commented on TS-2148:
-------------------------------------
I don't think the patch is good. I think that api_server_response_no_store
needs to be reset for shared sessions and KeepAlive. Otherwise if set it might
apply to future requests which would be bad.
Would the better choice be to remove the check in hcoofsr? It's already been
been incorporated via is_cacheable (which is called from other places as well).
Although, I do see the objection to status check methods that clear flags (and
are therefore non-idempotent).
> handle_cache_operation_on_forward_server_response ignores value of
> api_server_response_no_store
> -----------------------------------------------------------------------------------------------
>
> Key: TS-2148
> URL: https://issues.apache.org/jira/browse/TS-2148
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
> Reporter: Corey Cossentino
> Attachments: ts2148_response_no_store.patch
>
>
> In the function
> {{HttpTransact::handle_cache_operation_on_forward_server_response}} there is
> a line that checks the value of {{s->api_server_response_no_store}} (line
> 4162 in HttpTransact.cc). This value will never be true, however, because
> {{is_response_cacheable}} is called before this check (on line 3934) and sets
> this value to false (on line 6104).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
