[ 
https://issues.apache.org/jira/browse/TS-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619285#comment-13619285
 ] 

James Peach commented on TS-1736:
---------------------------------

I don't much like this patch; there is a problem with 
LocalManager::mgmtShutdown() clobberring "status" with waitpid() and I think 
the notion of this function calling exit() is flawed.

It seems to me that there is only 1 place that needs to call _exit() and that 
is the call from mgmt/Main.cc. Can we remove the _exit() form mgmtShutdown() 
and just call it in the one place it's needed? If you do that, you should also 
be able to remove the "status" argument from mgmtShutdown().
                
> Fatal() terminate process without logging backtrace
> ---------------------------------------------------
>
>                 Key: TS-1736
>                 URL: https://issues.apache.org/jira/browse/TS-1736
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Logging
>            Reporter: Yunkai Zhang
>            Assignee: James Peach
>             Fix For: 3.3.2
>
>         Attachments: 
> 0001-diags-Fatal-terminate-process-without-logging-backtr-V2.patch
>
>
> The root casue is that cleanup_func() was called before logging backtrace
> in Diags::error(), however cleanup_func() would terminate process by calling
> exit() directly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to