[ 
https://issues.apache.org/jira/browse/TS-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13567418#comment-13567418
 ] 

Uri Shachar commented on TS-1674:
---------------------------------

This may cause problems with our patch for TS-1631 (supporting the ability to 
reset individual stats).
I've been thinking that the 'correct' way to go here would be to unify all 
stats instead of maintaining a per thread copy -- thoughts?
                
> TSStatIntDecrement is broken
> ----------------------------
>
>                 Key: TS-1674
>                 URL: https://issues.apache.org/jira/browse/TS-1674
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: TS API
>            Reporter: Brian Geffon
>            Assignee: Brian Geffon
>             Fix For: 3.3.1
>
>
> ATS keeps a thread-local copy of the stat value and aggregates it 
> periodically and on demand when stats are being collected. However the 
> decrement function doesn't let a value go negative. So in a thread that has 
> not incremented this stat previously, the decrement call "fails". This 
> negative value check is logically flawed as it doesn't account for the 
> per-thread distribution of the stats.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to