kusalk commented on code in PR #766:
URL: https://github.com/apache/struts/pull/766#discussion_r1359882251
##########
core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java:
##########
@@ -143,12 +143,18 @@ protected void setEnableExpressionCache(String cache) {
enableExpressionCache = BooleanUtils.toBoolean(cache);
}
- @Inject(value = StrutsConstants.STRUTS_OGNL_EXPRESSION_CACHE_MAXSIZE,
required = false)
Review Comment:
Doesn't make much sense to inject this both in the factory and here. Plus,
~~Caffeine doesn't support changing the max size after construction~~ (and
neither does LRU really), ~~so we'd have to flush/reconstruct the cache to
continue supporting this method~~. I can't see much use for changing cache max
size mid-life anyway so I've just gone ahead and deprecated it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
