kusalk commented on code in PR #760:
URL: https://github.com/apache/struts/pull/760#discussion_r1347763341
##########
core/src/main/java/org/apache/struts2/dispatcher/multipart/JakartaMultiPartRequest.java:
##########
@@ -142,26 +142,22 @@ protected void processNormalFormField(FileItem item,
String charset) throws Unsu
}
long size = item.getSize();
- if (size == 0) {
- values.add(StringUtils.EMPTY);
- } else if (size > maxStringLength) {
+ if (size > maxStringLength) {
+ LOG.debug("Form field {} of size {} bytes exceeds limit of
{}.", item.getFieldName(), size, maxStringLength);
Review Comment:
I think logging the field name at the debug level is fine in terms of
security?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
