kusalk commented on code in PR #758:
URL: https://github.com/apache/struts/pull/758#discussion_r1345567133
##########
core/src/main/java/org/apache/struts2/util/StrutsUtil.java:
##########
@@ -125,12 +120,10 @@ public Object findValue(String expression, String
className) throws ClassNotFoun
public Object findValue(String expr, Object context) {
try {
- return ognl.getValue(expr,
ActionContext.getContext().getContextMap(), context);
- } catch (OgnlException e) {
- if (e.getReason() instanceof SecurityException) {
- LOG.error(format("Could not evaluate this expression due to
security constraints: [{0}]", expr), e);
- }
- return null;
+ stack.push(context);
Review Comment:
Should be outside the try block so that we don't pop unless successfully
pushed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
