[
https://issues.apache.org/jira/browse/WW-5312?focusedWorklogId=861882&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861882
]
ASF GitHub Bot logged work on WW-5312:
--------------------------------------
Author: ASF GitHub Bot
Created on: 20/May/23 23:29
Start Date: 20/May/23 23:29
Worklog Time Spent: 10m
Work Description: JCgH4164838Gh792C124B5 commented on PR #688:
URL: https://github.com/apache/struts/pull/688#issuecomment-1556042113
Hello Apache Struts Team.
The commit summary basically covers what is being attempted in the PR.
Other than some minor cleanup (in the modules where changes were made), the
changes were an attempt to fix the issue found with WW-5312.
The regression tests pass (locally), as well as interactive testing using
the Struts2 Showcase application, but the changes might still need
improvements. The ```SessionMap``` method signature changes appear to be
needed no matter what, though, in order to ensure the descendant method gets
called even when type erasure takes place (and having the ```@Override```
annotations present should help ensure the method signatures stay consistent).
Please review and advise if the PR looks OK, and if there are any
recommended changes.
_Note_: It looks like there was a "sonar-maven-plugin" failure for the Java
11 build environment run, but the build itself seems to have completed OK.
Possibly an issue with the automated build ?
Issue Time Tracking
-------------------
Worklog Id: (was: 861882)
Time Spent: 20m (was: 10m)
> ExecuteAndWaitInterceptor inconsistent wait processing behaviour
> ----------------------------------------------------------------
>
> Key: WW-5312
> URL: https://issues.apache.org/jira/browse/WW-5312
> Project: Struts 2
> Issue Type: Bug
> Components: Core, Core Interceptors
> Affects Versions: 6.1.2
> Environment: Java 8, Tomcat 8.5. The behaviour will likely be the
> same for other Java/Server combinations.
> Reporter: James Chaplin
> Priority: Minor
> Labels: pull-request-available
> Fix For: 6.2.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The _ExecuteAndWaitInterceptor_ processing appears to only execute as
> expected for the first run-through for any given session.
> This can be seen interactively using the Struts2 Showcase "_Execute and Wait
> Examples_", with the wait processing only functioning during the first
> attempt through each example in the same session. Clearing the session in
> the browser gives the expected wait behaviour again, but only one time (until
> clearing the session again).
> After debugging the _ExecuteAndWaitInterceptor_ flow, it appears that the
> removal from the _SessionMap_ did not perform as expected, resulting in a
> state divergence with the underlying session.
> A PR that attempts to fix the behaviour will be submitted soon.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
