[ 
https://issues.apache.org/jira/browse/WW-5267?focusedWorklogId=848269&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-848269
 ]

ASF GitHub Bot logged work on WW-5267:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Mar/23 10:18
            Start Date: 01/Mar/23 10:18
    Worklog Time Spent: 10m 
      Work Description: kusalk commented on code in PR #663:
URL: https://github.com/apache/struts/pull/663#discussion_r1121470998


##########
core/src/main/java/org/apache/struts2/dispatcher/filter/StrutsPrepareFilter.java:
##########
@@ -44,6 +46,12 @@ public class StrutsPrepareFilter implements StrutsStatics, 
Filter {
 
     protected PrepareOperations prepare;
     protected List<Pattern> excludedPatterns = null;
+    protected boolean alwaysCreateActionContext = false;
+
+    @Inject(value = StrutsConstants.STRUTS_ALWAYS_CREATE_ACTION_CONTEXT, 
required = false)

Review Comment:
   Actually - we can't inject here can we? 😬





Issue Time Tracking
-------------------

    Worklog Id:     (was: 848269)
    Time Spent: 0.5h  (was: 20m)

> Add configuration option to generate ActionContext even for excluded urls
> -------------------------------------------------------------------------
>
>                 Key: WW-5267
>                 URL: https://issues.apache.org/jira/browse/WW-5267
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Kusal Kithul-Godage
>            Priority: Minor
>             Fix For: 6.2.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> There are scenarios where you may want to except a request from Struts 
> filtering/processing using `struts.action.excludePattern`, however you may 
> still want that request to undergo filtering such as SiteMesh, which requires 
> the ActionContext to be present.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to