[
https://issues.apache.org/jira/browse/WW-5285?focusedWorklogId=847676&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-847676
]
ASF GitHub Bot logged work on WW-5285:
--------------------------------------
Author: ASF GitHub Bot
Created on: 26/Feb/23 11:10
Start Date: 26/Feb/23 11:10
Worklog Time Spent: 10m
Work Description: yasserzamani commented on code in PR #662:
URL: https://github.com/apache/struts/pull/662#discussion_r1118064990
##########
core/src/main/java/org/apache/struts2/dispatcher/multipart/AbstractMultiPartRequest.java:
##########
@@ -54,6 +54,12 @@ public abstract class AbstractMultiPartRequest implements
MultiPartRequest {
protected long maxSize;
protected boolean maxSizeProvided;
+ /**
+ * Specifies the maximum number of files in one request.
+ */
+ protected long maxFiles;
+ protected boolean maxFilesProvided;
Review Comment:
nitpick: can't we use Long instead of long here? and a null value will mean
that it's not provided
Issue Time Tracking
-------------------
Worklog Id: (was: 847676)
Time Spent: 0.5h (was: 20m)
> Upgrade commons-fileupload to ver 1.5 and add option to limit number of
> accepted files
> --------------------------------------------------------------------------------------
>
> Key: WW-5285
> URL: https://issues.apache.org/jira/browse/WW-5285
> Project: Struts 2
> Issue Type: Improvement
> Components: Core
> Reporter: Lukasz Lenart
> Assignee: Lukasz Lenart
> Priority: Major
> Fix For: 6.2.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> With a new version of commons-fileupload a new option has been added to limit
> number of uploaded files (not size, but number). It would be good to support
> this in Struts as well by adding a new constant "struts.multipart.maxFiles"
> [https://github.com/apache/commons-fileupload/pull/185]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
