[jira] [Work logged] (WW-4514) DefaultUrlHelper.buildParametersString appends just ? if collection is empty

Fri, 04 Nov 2022 01:22:03 -0700 


     [ 
https://issues.apache.org/jira/browse/WW-4514?focusedWorklogId=823304&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-823304
 ]

ASF GitHub Bot logged work on WW-4514:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Nov/22 08:21
            Start Date: 04/Nov/22 08:21
    Worklog Time Spent: 10m 
      Work Description: sonarcloud[bot] commented on PR #630:
URL: https://github.com/apache/struts/pull/630#issuecomment-1303106330

   Kudos, SonarCloud Quality Gate passed!    [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=630)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=630&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=630&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=630&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=630&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=630&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=630&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=630&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=630&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=630&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=630&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=630&resolved=false&types=CODE_SMELL)
 [3 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=630&resolved=false&types=CODE_SMELL)
   
   
[![97.1%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/90-16px.png
 
'97.1%')](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=630&metric=new_coverage&view=list)
 [97.1% 
Coverage](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=630&metric=new_coverage&view=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=630&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=630&metric=new_duplicated_lines_density&view=list)
   
   




Issue Time Tracking
-------------------

    Worklog Id:     (was: 823304)
    Time Spent: 50m  (was: 40m)

> DefaultUrlHelper.buildParametersString appends just ? if collection is empty
> ----------------------------------------------------------------------------
>
>                 Key: WW-4514
>                 URL: https://issues.apache.org/jira/browse/WW-4514
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Actions
>    Affects Versions: 2.3.24
>            Reporter: Jasper Rosenberg
>            Assignee: Lukasz Lenart
>            Priority: Trivial
>             Fix For: 6.1.0
>
>         Attachments: DefaultUrlHelper.patch
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> DefaultUrlHelper.buildParametersString() checks that it has parameters to 
> append before adding the first "?"/"&", but if the only parameters are empty 
> Iterables/Arrays, then it shouldn't do that.
> I'd suggest adding the new query string to a StringBuilder, and then if it is 
> non-empty, append that with the separator to the link at the end. (See patch)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to