[
https://issues.apache.org/jira/browse/WW-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17628763#comment-17628763
]
ASF subversion and git services commented on WW-4514:
-----------------------------------------------------
Commit 4a51aacf406bdb81a3d1c0ae975c8e47c298bdc2 in struts's branch
refs/heads/WW-4514-url from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=4a51aacf4 ]
WW-4514 Avoids logging user provided data
> DefaultUrlHelper.buildParametersString appends just ? if collection is empty
> ----------------------------------------------------------------------------
>
> Key: WW-4514
> URL: https://issues.apache.org/jira/browse/WW-4514
> Project: Struts 2
> Issue Type: Bug
> Components: Core Actions
> Affects Versions: 2.3.24
> Reporter: Jasper Rosenberg
> Assignee: Lukasz Lenart
> Priority: Trivial
> Fix For: 6.1.0
>
> Attachments: DefaultUrlHelper.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> DefaultUrlHelper.buildParametersString() checks that it has parameters to
> append before adding the first "?"/"&", but if the only parameters are empty
> Iterables/Arrays, then it shouldn't do that.
> I'd suggest adding the new query string to a StringBuilder, and then if it is
> non-empty, append that with the separator to the link at the end. (See patch)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
