Suvrat1629 commented on issue #3433: URL: https://github.com/apache/streampipes/issues/3433#issuecomment-2678383853
@tenthe >It would be good to have one or more expressive methods where it is clear what is happening and how they can be used. Yes, I did notice that while going through the code which is why i proposed to move all the `setup` logic of the adapter in one method. > Have you ever worked with cypress tests? Or have you ever run the tests for StreamPipes locally? I have worked with cypress before but not so much, although I haven't run the StreamPipes tests locally (my system isnt really a fan of test cases, it cannot bear with the heat) but I was working on an old [good-first-issue](https://github.com/apache/streampipes/issues/1904) which deals with test cases.(I will open a pr for this shortly) >You are also welcome to look at where the methods are used and then make a suggestion on how to improve the API. I did take a look at the various places these methods were used but I am new to the code base so I lack a bit of understanding about what exactly is happening here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@streampipes.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
