muyangye commented on issue #1688: URL: https://github.com/apache/streampipes/issues/1688#issuecomment-1696948042
I have finished the implementation and tested locally using a FileStream source, should I submit a PR now (sorry if this is a dumb question, this is my first time contributing to OSS)? That being said, I still have 4 questions (and my current approach): - I am using Labels.from() to create a label and according to source code this method is marked as deprecated. Is this a problem? - Just want to confirm the exact meaning of rounding, currently I am using the conventional round half up. - When I try to update the new processor, there's an error message "Icon missing", is there a place to add an icon to the processor? - This question is not really related to this processor but I am curious: Why only event.addField()'s implementation uses runtime name (what's after s0::) and other functions such as getFieldBySelector() and removeFieldBySelector() use the selector? Cheers, Muyang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@streampipes.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
