tenthe commented on issue #777: URL: https://github.com/apache/streampipes/issues/777#issuecomment-1365667813
Hi @flomickl, was there a specific reason why you changed the method API of `Event.addField(String runtimeName, Float value)` to `Event.addField(String runtimeName, double value)`? The nightly e2e tests failed for the `BooleanCounter` processor, because the datatype of the counter (an integer) was changed to a double. I changed the API back to `Float` but wanted to make sure that this does not break any of the other changes you made in the PR. Cheers, Philipp See [1] for my changes and [2] for the e2e test results. [1] https://github.com/apache/streampipes/commit/7dfe113dc6b30cf20513a4bf69199c50e03bfe79 [2] https://cloud.cypress.io/projects/q1jdu2/runs/401/specs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
