wolfboys commented on code in PR #3989:
URL:
https://github.com/apache/incubator-streampark/pull/3989#discussion_r1728215291
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/task/FlinkAppHttpWatcher.java:
##########
@@ -575,6 +578,7 @@ and the status is not obtained this time (flink rest server
is closed),
if (trackingUrl != null &&
!trackingUrl.equals(application.getJobManagerUrl())) {
application.setJobManagerUrl(trackingUrl);
applicationService.updateJobManagerUrl(application.getId(),
trackingUrl);
+ applicationLogService.updateJobManagerUrl(application.getId(),
trackingUrl);
Review Comment:
> 1. We only need to update the jobmanager url while the job is still
running, not killed and cancelled states
> 2. The job history interface is displayed to use the jobmanagerurl, if you
do not update this place to show link errors.
In the t_flink_log table, an application (appid) may be inserted multiple
times. Each operation (app build, app start, app stop, app release) will record
information about this app. This PR will modify all records of the app, which
will result in logical errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
