Al-assad commented on code in PR #3314:
URL:
https://github.com/apache/incubator-streampark/pull/3314#discussion_r1382882982
##########
streampark-flink/streampark-flink-client/streampark-flink-client-core/src/main/scala/org/apache/streampark/flink/client/impl/KubernetesApplicationClientV2.scala:
##########
@@ -103,12 +103,15 @@ object KubernetesApplicationClientV2 extends
KubernetesClientV2Trait with Logger
.filter(str => StringUtils.isNotBlank(str))
.getOrElse(return Left("Flink base image should not be empty"))
- val ingress = submitReq.k8sSubmitParam.ingressDefinition
+ val ingress = Option(submitReq.k8sSubmitParam.ingressDefinition)
+ .getOrElse(return Left("Ingress should not be empty"))
- val imagePullPolicy = flinkConfObj
- .getOption(KubernetesConfigOptions.CONTAINER_IMAGE_PULL_POLICY)
- .map(_.toString)
- .orElse(submitReq.k8sSubmitParam.imagePullPolicy)
+ val imagePullPolicy = Option(
Review Comment:
imagePullPolicy is a Option[String] here which is not mandatory to have a
value.
##########
streampark-flink/streampark-flink-client/streampark-flink-client-core/src/main/scala/org/apache/streampark/flink/client/impl/KubernetesApplicationClientV2.scala:
##########
@@ -142,14 +145,17 @@ object KubernetesApplicationClientV2 extends
KubernetesClientV2Trait with Logger
.orElse(submitReq.k8sSubmitParam.jobManagerMemory)
.getOrElse(KUBERNETES_JM_MEMORY_DEFAULT)
+ val ephemeralStorage =
Option(submitReq.k8sSubmitParam.jobManagerEphemeralStorage)
Review Comment:
ephemeralStorage is is not a required parameter
##########
streampark-flink/streampark-flink-client/streampark-flink-client-core/src/main/scala/org/apache/streampark/flink/client/impl/KubernetesApplicationClientV2.scala:
##########
@@ -103,12 +103,15 @@ object KubernetesApplicationClientV2 extends
KubernetesClientV2Trait with Logger
.filter(str => StringUtils.isNotBlank(str))
.getOrElse(return Left("Flink base image should not be empty"))
- val ingress = submitReq.k8sSubmitParam.ingressDefinition
+ val ingress = Option(submitReq.k8sSubmitParam.ingressDefinition)
Review Comment:
ingress should be a Option[IngressDef] here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
