wolfboys commented on code in PR #3315:
URL:
https://github.com/apache/incubator-streampark/pull/3315#discussion_r1382526253
##########
streampark-flink/streampark-flink-client/streampark-flink-client-api/src/main/scala/org/apache/streampark/flink/client/bean/DeployResponse.scala:
##########
@@ -17,4 +17,11 @@
package org.apache.streampark.flink.client.bean
-case class DeployResponse(address: String, clusterId: String)
+import javax.annotation.Nullable
+
+import java.util.{Map => JavaMap}
+
+case class DeployResponse(
+ @Nullable address: String = "",
+ clusterId: String,
+ flinkConfig: JavaMap[String, String])
Review Comment:
> The flinkconfig parameter is very important during the deployment process
I see that we don't currently need this parameter, so I think it would be
more appropriate to add it when we actually need it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
