[ 
https://issues.apache.org/jira/browse/SPARK-60149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vito Lin updated SPARK-60149:
-----------------------------
    Description: 
Several code paths in python/pyspark/errors/utils.py (ErrorClassesReader) are 
not covered by tests:

1. get_message_template: raising ValueError when the main class exists but the 
sub-class does not
2. get_breaking_change_info:
   2.1 returning None for a None error class
   2.2 raising ValueError for an unknown main class or sub-class
   2.3 falling back to the main class's breaking_change_info when the sub-class 
has none
   2.4 returning None when neither the main class nor the sub-class declares it
3. get_sqlstate: returning None for a None error class

This ticket adds tests for these paths in 
python/pyspark/errors/tests/test_errors.py.

  was:
Several code paths in {{python/pyspark/errors/utils.py}} 
({{ErrorClassesReader}}) are not covered by tests:

{{}}
{{1. get_message_template: raising ValueError when the main class exists but 
the sub-class does not}}
{{2. get_breaking_change_info: }}
    2.1 {{returning None for a None error class}}
    2.2 {{raising ValueError for an unknown main class or sub-class}}
    2.3 {{falling back to the main class's breaking_change_info when the 
sub-class has none}}
{{  2.4 returning None when neither the main class nor the sub-class declares 
it}}
{{{}3. get_sqlstate(None): returning None{}}}{{{}{}}}
{{}}
{{This ticket adds tests for these paths in 
}}python/pyspark/errors/tests/test_errors.py{{{}{}}}
 

 

 


> Add test for ErrorClassesReader lookup errors and breaking_change_info
> ----------------------------------------------------------------------
>
>                 Key: SPARK-60149
>                 URL: https://issues.apache.org/jira/browse/SPARK-60149
>             Project: Spark
>          Issue Type: Test
>          Components: PySpark
>    Affects Versions: 5.0.0
>            Reporter: Vito Lin
>            Priority: Minor
>
> Several code paths in python/pyspark/errors/utils.py (ErrorClassesReader) are 
> not covered by tests:
> 1. get_message_template: raising ValueError when the main class exists but 
> the sub-class does not
> 2. get_breaking_change_info:
>    2.1 returning None for a None error class
>    2.2 raising ValueError for an unknown main class or sub-class
>    2.3 falling back to the main class's breaking_change_info when the 
> sub-class has none
>    2.4 returning None when neither the main class nor the sub-class declares 
> it
> 3. get_sqlstate: returning None for a None error class
> This ticket adds tests for these paths in 
> python/pyspark/errors/tests/test_errors.py.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to