[
https://issues.apache.org/jira/browse/SPARK-59973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
L. C. Hsieh resolved SPARK-59973.
---------------------------------
Fix Version/s: connect-gateway-0.1.0
Resolution: Fixed
Issue resolved by pull request 43
[https://github.com/apache/spark-connect-gateway/pull/43]
> Upgrade the OpenTelemetry crates to 0.33 and tracing-opentelemetry to 0.34
> --------------------------------------------------------------------------
>
> Key: SPARK-59973
> URL: https://issues.apache.org/jira/browse/SPARK-59973
> Project: Spark
> Issue Type: Sub-task
> Components: Connect
> Affects Versions: connect-gateway-0.1.0
> Reporter: L. C. Hsieh
> Assignee: L. C. Hsieh
> Priority: Major
> Labels: pull-request-available
> Fix For: connect-gateway-0.1.0
>
>
> Move the six opentelemetry* crates from 0.32 to 0.33, and
> tracing-opentelemetry from 0.33 to 0.34.
> These versions have to move together: the crates share types across their
> public APIs, so raising one on its own leaves two majors of opentelemetry in
> the dependency graph and the traits stop lining up. tracing-opentelemetry's
> version is offset by one minor -- 0.34 is the release that tracks
> opentelemetry 0.33 -- which is why eight crates move for what reads as one
> upgrade. This is the same shape as SPARK-59548, which took the group from
> 0.31 to 0.32.
> Dependabot raised this correctly as a single grouped PR (#41), under the
> grouping added in SPARK-59550, rather than as the seven unmergeable
> single-crate PRs it would have produced before. That PR is superseded by
> this
> one and closed; its branch predated the proto work on main.
> No source changes were needed: the APIs this repo uses are unchanged between
> 0.32 and 0.33.
> Verified:
> The check that actually shows the version skew is gone is the lockfile
> resolving a single opentelemetry -- building is not sufficient proof, since
> a
> skewed graph can still compile until the mismatched trait is named:
> $ grep -c '^name = "opentelemetry"$' Cargo.lock
> 1
> opentelemetry and opentelemetry_sdk resolve to 0.33.0 and
> tracing-opentelemetry to 0.34.0, and cargo metadata --locked confirms the
> lock
> agrees with the manifest.
> The tracing integration test matters more here than the unit tests and
> passes:
> tracing_emits_spans_and_propagates_traceparent. Feature unification in this
> dependency group has previously caused application spans to be dropped
> silently -- enabling opentelemetry's spec_unstable_logs_enabled through an
> unrelated path made the linked tracing-opentelemetry discard them -- and
> neither a build nor the unit tests would catch that. The nine Redis
> integration tests were run as well and are unaffected, as expected.
> Full workspace: 204 tests pass, matching the baseline on main, with
> cargo clippy --workspace --all-targets -D warnings and cargo fmt --check
> clean.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
