[
https://issues.apache.org/jira/browse/SPARK-59493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uroš Bojanić updated SPARK-59493:
---------------------------------
Component/s: Tests
> Add execution-metric test coverage for the ASOF JOIN sort-merge operator
> ------------------------------------------------------------------------
>
> Key: SPARK-59493
> URL: https://issues.apache.org/jira/browse/SPARK-59493
> Project: Spark
> Issue Type: Improvement
> Components: SQL, Tests
> Affects Versions: 5.0.0
> Reporter: Luka Zdravic
> Assignee: Luka Zdravic
> Priority: Minor
> Labels: pull-request-available
>
> Test-only change. No production code.
> The operator SortMergeAsOfJoinExec runs the sort-merge form of ASOF JOIN. It
> reports two metrics, numOutputRows and spillSize, but no test checks either,
> and SQLMetricsSuite has no entry for it. Every other join operator has a
> metrics test there.
> This adds:
> - A "SortMergeAsOfJoin metrics" test in SQLMetricsSuite for numOutputRows
> (inner and left outer), matching the existing "SortMergeJoin metrics" test.
> - A "spillSize > 0" check in the existing spill tests, which today check only
> the result rows.
> Without this, a change that broke a metric would still pass, because the
> tests check results but never the metrics.
> Umbrella: SPARK-59298
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
