Nicholas Chammas created SPARK-59565:
----------------------------------------
Summary: Ensure that ignored files are not also included in test
modules
Key: SPARK-59565
URL: https://issues.apache.org/jira/browse/SPARK-59565
Project: Spark
Issue Type: Sub-task
Components: Build
Affects Versions: 4.3.0
Reporter: Nicholas Chammas
Over time, we may inadvertently name a file both as an ignored file and as a
file that must trigger some tests. That's a problem and we want to prevent that
so that explicitly tested paths are not unintentionally ignored.
At the same time, we want some flexibility to allow ourselves to ignore
patterns or directories while still selecting more specific paths within them
for tests.
If a file is ignored by directory but tested by name or vice versa, that's OK.
That is, this combination is OK:
- ignore `README.md`
- run core tests for everything under `core/`
- `core/README.md` doesn't trigger core tests
This one is also OK:
- ignore `dev/`
- run Python linter for everything matching `**/*.py`
- linter will _not_ trigger on changes to `dev/file.py`
On the other hand, if a file is both ignored and tested by name, that's almost
certainly unintentional and should trigger a build failure.
That is, this combination is not OK:
- ignore `dev/file.py`
- run tests for `dev/file.py`
This is also not OK:
- ignore `test.py`
- run python lint tests for `**/*.py`
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
