[ 
https://issues.apache.org/jira/browse/SPARK-58662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated SPARK-58662:
-----------------------------------
    Labels: pull-request-available  (was: )

> Remove redundant toString in RocksDBStateStoreProvider state transition 
> messages
> --------------------------------------------------------------------------------
>
>                 Key: SPARK-58662
>                 URL: https://issues.apache.org/jira/browse/SPARK-58662
>             Project: Spark
>          Issue Type: Improvement
>          Components: Structured Streaming
>    Affects Versions: 4.3.0
>            Reporter: Uroš Bojanić
>            Priority: Major
>              Labels: pull-request-available
>
> Four error message interpolations in 
> RocksDBStateStoreProvider.validateAndTransitionState call toString on an 
> embedded value, as in s"Cannot update after ${oldState.toString}". String 
> interpolation already stringifies embedded values through String.valueOf, so 
> the call is redundant. The METRICS branch in the same match already omits it.
> This drops the redundant calls from the other four branches so all five read 
> the same way. oldState is a case object with a compiler generated toString, 
> so the rendered text is unchanged.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to