[ 
https://issues.apache.org/jira/browse/SPARK-17163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15436335#comment-15436335
 ] 

DB Tsai edited comment on SPARK-17163 at 8/25/16 6:06 PM:
----------------------------------------------------------

I voted for merging into one interface as well. Since binary LOR can be 
represented as matrix like MLOR we can always return matrix and intercepts for 
BLOR and MLOR. For MLOR, I feel like flatten the matrix and set intercept as 
zero is too hacky, and we could just throw exception. Finally, we can set two 
classes problem default to pivoting, and classes larger than 2 use MLOR without 
pivoting. I like what Yanbo suggested, and we can default to auto. Users can 
make it binomial or multinomial. Thanks. 



was (Author: dbtsai):
I voted for merging into one interface as well. Since binary LOR can be 
represented as matrix like MLOR we can always return matrix and intercepts for 
BLOR and MLOR. For BLOR, I feel like flatten the matrix and set intercept as 
zero is too hacky, and we could just throw exception. Finally, we can set two 
classes problem default to pivoting, and classes larger than 2 use MLOR without 
pivoting. I like what Yanbo suggested, and we can default to auto. Users can 
make it binomial or multinomial. Thanks. 


> Merge MLOR into a single LOR interface
> --------------------------------------
>
>                 Key: SPARK-17163
>                 URL: https://issues.apache.org/jira/browse/SPARK-17163
>             Project: Spark
>          Issue Type: Sub-task
>          Components: ML, MLlib
>            Reporter: Seth Hendrickson
>
> Before the 2.1 release, we should finalize the API for logistic regression. 
> After SPARK-7159, we have both LogisticRegression and 
> MultinomialLogisticRegression models. This may be confusing to users and, is 
> a bit superfluous since MLOR can do basically all of what BLOR does. We 
> should decide if it needs to be changed and implement those changes before 2.1
> *Update*: Seems we have decided to merge the two estimators. I changed the 
> title to reflect that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to