nick-boss-tech commented on code in PR #5339:
URL: https://github.com/apache/solr/pull/5339#discussion_r4581698576


##########
solr/core/src/java/org/apache/solr/update/processor/TextProfileSignature.java:
##########
@@ -35,7 +35,7 @@
  *   <li>remove all characters except letters and digits, and bring all 
characters to lower case,
  *   <li>split the text into tokens (all consecutive non-whitespace 
characters),
  *   <li>discard tokens equal or shorter than MIN_TOKEN_LEN (default 2 
characters),
- *   <li>sort the list of tokens by decreasing frequency,
+ *   <li>sort the list of tokens by decreasing frequency (ties broken by token 
string),

Review Comment:
   Could the Javadoc list the sorting step after quantization and filtering, to 
match the order in the implementation?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to