janhoy commented on PR #5337: URL: https://github.com/apache/solr/pull/5337#issuecomment-6900650135
Thanks @nick-boss-tech, these look like real findings, especially the Windows `solr.cmd` exit-code mapping, which is easy to miss. A couple of suggestions on the format, mostly to make things easier for the PR author and for anyone reading the history later: * **Inline review comments** on the relevant lines make it clear exactly where each issue is. Each one also gets its own thread that can be discussed and resolved separately. With one big top-level comment, the replies pile up in a single place and get hard to follow, especially when there are several issues. * **Problems first, code second.** I know you asked whether to include your changes, but a ready-made branch with merge instructions is hard to say no to, especially for newer contributors. The author's choice turns from "how do I solve this?" into "do I accept someone else's solution?" @iprithv owns this PR. Working through the feedback themselves is how contributors grow into the codebase, and how we get to know each other. I'd describe the problems and leave the first move to the author. Offering to help if they get stuck is great. @iprithv, please feel free to address these in your own way. There's no expectation that you take the branch. None of this is a criticism of the effort. It's great to see how contributors solve a JIRA opened by someone else, and also how contributor help review each other's PRs. I just want to make sure that as our tools make it ever faster to produce reviews and fixes, we keep the parts that make this a community: reading each other's feedback, discussing it, sometimes backtracking and rethinking a solution together. Community over Code, as we say at the ASF 🙂 I've seen this style of review on a number of PRs lately, so perhaps we should start a thread on dev@ about how we want AI-assisted reviews and fixes to work in the project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
