nick-boss-tech commented on PR #5336:
URL: https://github.com/apache/solr/pull/5336#issuecomment-6868408020

   🤖 *AI text below* 🤖 *(reviewed by Nick Shanin)*
   
   Hi @isaric, I prepared a [test-only 
follow-up](https://github.com/nick-boss-tech/solr/compare/96df2d214560949cb8984b16aad1a2b7f47ca7d7...59c259bcb28bac589b0617f72b52d23701442100)
 with JSON response-format checks for overseer status, collection snapshots, 
backup purge and replication backup deletion. The follow-up also clarifies the 
upgrade note and changelog: SolrJ decodes the changed sections as 
`SimpleOrderedMap`, while casts to `NamedList` remain valid.
   
   <details>
   <summary>Test-only changes validation</summary>
   
   At `59c259bcb28bac589b0617f72b52d23701442100`, 10 focused tests passed with 
no skips. Tidy and `check -x test -Prefguide.include=false` passed; the latter 
excluded the reference guide. I also reverted each of eight converted 
constructors separately: each change compiled and caused the matching JSON 
assertion to fail. These are coverage checks; the original PR tests can pass 
with the added tests too. The install-shard partial-failure and recovery 
response remains untested.
   
   </details>
   
   The follow-up is a fast-forward of the current PR head:
   
   ```sh
   git switch SOLR-18612-core-admin-apis
   git fetch https://github.com/nick-boss-tech/solr.git 
pr-5336-response-followup
   git merge --ff-only 59c259bcb28bac589b0617f72b52d23701442100
   ```
   
   Would you like to include these tests and the wording clarification in this 
PR?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to