github-actions[bot] commented on PR #5075:
URL: https://github.com/apache/solr/pull/5075#issuecomment-6857652349

   **Automated PR readiness judgements** (LLM-generated; may be wrong; not 
updated on later pushes).
   
   - ✅ [Jira issue in 
title](https://github.com/apache/solr/blob/main/CONTRIBUTING.md): already 
present
   - ✅ 
[Changelog](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc#_changelog_types_reference):
 type: fixed <!-- The change fixes a bug where errors from a failed merged 
update stream were only recorded against the first request&#44; causing 
incorrect retry and failure accounting for other requests in the stream&#46;​ 
The author&#39;s changelog entry also explicitly specifies the type as 
&#39;fixed&#39;&#46;​ -->
   - ✅ [Reference Guide 
update](https://github.com/apache/solr/tree/main/solr/solr-ref-guide): not 
needed <!-- This is an internal fix to the distributed update error handling 
logic and SolrJ client implementation&#46;​ It does not introduce new request 
parameters&#44; configuration options&#44; or user&#45;facing API changes that 
require Reference Guide documentation&#46;​ -->
   - ✅ [Upgrade 
notes](https://github.com/apache/solr/tree/main/solr/solr-ref-guide/modules/upgrade-notes/pages):
 not needed <!-- While the behavior of error attribution changes &#40;errors 
are now recorded per request instead of just the first&#41;&#44; this is a bug 
fix that corrects incorrect behavior&#46;​ It does not remove or rename 
APIs&#44; parameters&#44; or configuration elements&#44; nor does it change 
defaults in a way that requires user action to maintain compatibility&#46;​ -->
   - ✅ Tests: included <!-- The PR modifies non&#45;trivial production logic in 
&#96;StreamingSolrClients&#96;&#44; 
&#96;ConcurrentUpdateBaseSolrClient&#96;&#44; and 
&#96;TolerantUpdateProcessor&#96; to change how errors are attributed and 
counted&#46;​ The description mentions new tests 
&#40;&#96;StreamingSolrClientsErrorAttributionTest&#96;&#41; and notes that the 
tolerant&#45;path change lacks a new test in this branch&#44; indicating that 
tests are required for this logic change&#46;​ -->
   
   <!-- Assessed commit 5b3693c44ca057dc42addb43af97c168634d6301 -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to