epugh opened a new pull request, #5329:
URL: https://github.com/apache/solr/pull/5329

   ## Summary
   - `bin/solr` now automatically secures the embedded ZooKeeper's transport 
with TLS, reusing Solr's own keystore/truststore, whenever 
`SOLR_SSL_ENABLED=true` and Solr is starting its own embedded ZooKeeper (no 
`-z`/`--zk-host`). No new flag to set — this is a behavior change on upgrade 
for any such deployment, not just the secure example below.
   - The matching `zookeeper.ssl.*`/`zookeeper.client.secure` flags are 
persisted into the include file as `SOLR_ZK_TLS_OPTS`, so co-located nodes and 
`bin/solr zk`/`auth` commands inherit them automatically without repeating them 
by hand.
   - Has no effect on an external ZooKeeper ensemble (`-z`/`--zk-host`): Solr 
has no way to know whether an external, independently-administered ensemble 
uses TLS, so nothing is assumed there — it must be secured independently, on 
that ensemble.
   - `bin/solr.cmd` (Windows) is not supported for this; it now prints an 
explicit warning instead of silently staying plaintext.
   - `SolrZkServer.java` is fixed to honor a `secureClientPort`-only `zoo.cfg` 
instead of always defaulting a plaintext `clientPort`, which is what made a 
TLS-only embedded ZooKeeper possible.
   - The `bin/solr start -e secure` example and tutorial (from #5306) now rely 
on this automatic behavior instead of hand-rolling the same TLS setup 
themselves.
   
   ## Test plan
   - [x] `solr/packaging/test/test_secure_example.bats` passes
   - [x] Manual walkthrough of every updated tutorial command block against a 
built distribution (two-node start, HTTPS enablement + automatic ZK TLS, auth, 
ACL migration, admin/readonly/anonymous-TLS/plaintext-timeout checks)
   - [x] Manual check that a plain `bin/solr start -c` with 
`SOLR_SSL_ENABLED=true` (no `-z`) also secures its embedded ZooKeeper 
automatically
   - [x] Confirmed by inspection that the `-z`/external-ZK code path is 
structurally unreachable by the new logic
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   
   https://claude.ai/code/session_018RwsEje8u9apx3SRzissZm


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to