epugh commented on code in PR #5190: URL: https://github.com/apache/solr/pull/5190#discussion_r4553207694
########## solr/bin/solr.cmd: ########## @@ -422,8 +422,8 @@ IF "%1"=="-h" goto check_picocli_help goto after_help_check :check_picocli_help -IF "%SOLR_PICOCLI%"=="true" goto run_picocli_help -goto usage +IF "%SOLR_PICOCLI%"=="false" goto usage +goto run_picocli_help Review Comment: this is fine, but in the future, won't this be "run_help" or become "usage"? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
