janhoy commented on PR #4710: URL: https://github.com/apache/solr/pull/4710#issuecomment-6824426811
🤖 Rebased on current `main` (`2b0eb4962ba`) and removed the temporary `.github/workflows/windows-solr-cmd-test.yml`, which was only scaffolding for trying this out on Windows CI. A plain rebase re-opened the August→November drift in `StatusTool.java` that this branch's merge commit had already resolved, so instead the pre-merge commits and that resolution are now one commit and the four later commits replay on top. The net diff is unchanged from what was already reviewed here, minus the workflow. Self-review turned up one thing the rebase made stale: `--port` is now declared twice in `StatusTool`, once per parser, and only the commons-cli twin carried the reworded description. Aligned the picocli annotation and regenerated `pages/cli/solr-status.adoc` from it. Nothing else — no leftover debugging, and the changelog entry still describes what the patch does. Verified: `SolrProcessManagerTest` (11 tests), `StatusToolTest` + `StatusToolPicocliTest`, and `:solr:core:check -x test` all pass locally. Worth noting for merge: this bug now has a second, independent reproduction. The new cross-platform CLI test suite (SOLR-18642, #5323) hits the same hardcoded-`localhost` probe through Jetty's SNI host check rather than through a non-loopback bind, and its test is marked `@AwaitsFix` against SOLR-18336 until this lands. Evidence is on SOLR-18336. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
